eduucaldas added inline comments.
================ Comment at: clang/include/clang/Tooling/Syntax/Tree.h:269 + return EDI == Other.EDI; + } + ---------------- gribozavr2 wrote: > Please also define `operator!=`. this is defined by the `iterato_facade_base`, take a look at the comments in this class template ================ Comment at: clang/lib/Tooling/Syntax/Tree.cpp:405 return Children; } ---------------- gribozavr2 wrote: > Ditto? Here we could do `std::transform(getBegin(), getEnd(), std::back_inserter(result), [](ElementAndDelimiter ED){return ED.element;})`. Is that more idiomatic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits