mstorsjo added a comment. I see that the llvm side of the patch lacks tests?
================ Comment at: llvm/lib/IR/AsmWriter.cpp:379 + Out << "aarch64_darwincc"; + break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; ---------------- The new code here has a different indentation than the rest; the same in a couple other places throughout the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
