rsmith added inline comments.
================ Comment at: clang/test/CodeGen/X86/avx-union.c:7 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx512f -fclang-abi-compat=11.0 -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK-LEGACY --check-prefix=AVX512-LEGACY +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-scei-ps4 -target-feature +avx -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK-LEGACY --check-prefix=AVX-LEGACY + ---------------- dyung wrote: > rsmith wrote: > > There are no added `CHECK` lines for `--check-prefix=AVX-LEGACY`. Is that > > intentional, or is there a `AVX-LEGACY:` line missing from the test below? > It was intentional since the AVX-LEGACY was the same. I debated putting it in > to make it clearer, but decided to leave it out thinking it might cause more > confusing to see two identical CHECK lines. If there are no check lines corresponding to this check-prefix, it'd be better to not list it to avoid confusing future readers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89747/new/ https://reviews.llvm.org/D89747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
