jhuber6 added inline comments.

================
Comment at: clang/test/OpenMP/driver-openmp-target.c:2
+// REQUIRES: x86-registered-target
+// REQUIRES: clang-64-bits
+// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 
-fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck 
--check-prefix=CHECK-45-VERSION --check-prefix=CHECK-45-VERSION2 %s
----------------
daltenty wrote:
> This tests still fails on AIX, presumably because we have a 64-bit host but 
> the compiler is targeting 32-bit by default:
> 
> ```
> error: OpenMP target architecture 'x86_64-unknown-unknown' pointer size is 
> incompatible with host 'powerpc-ibm-aix7.2.0.0'
> ```
> 
> Maybe adjust the test to check the default target instead of just the host?
I'm not aware of any easy methods to do that, though one might exist. Easiest 
solution is just add a check that doesn't run this test on AIX, more complex 
would probably require taking the default target from the clang executable and 
parsing it using the same methods that Triple.cpp uses to get the architecture 
size. I'm not familiar with anything about AIX, any suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89696/new/

https://reviews.llvm.org/D89696

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to