steakhal added a comment. @ASDenysPetrov Please grep for the `SymbolRef` and rename the other symbols/comments as well, especially the compound names.
In D89987#2348935 <https://reviews.llvm.org/D89987#2348935>, @OikawaKirie wrote: > Since `SymbolRef` is just a `const SymExpr *` in the current codebase, I'd > prefer using `const SymExpr *` directly, just like how `MemRegion` is used, > which would be clearer than both `SymbolRef` and `SymExprRef` as far as I am > thinking. IMO using `SymExprRef` is more readable. However, I don't have any strong opinion on this. > Different from `ProgramStateRef` which is an alias to `IntrusiveRefCntPtr`, > or `StoreRef` which is a wrapper object, an alias to a `const SymExpr *` > makes no sense to me. > And this is also where I have been confused for a long while. > > Or on the opposite, do we also need a similar alias for a `const MemRegion > *`, maybe say `MemRegionRef`? After all, it is shorter. :-) Yes, that would make the codebase more consistant. ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h:111 +using SymExprRef = const SymExpr *; +using SymbolRefSmallVectorTy = SmallVector<SymExprRef, 2>; using SymbolID = unsigned; ---------------- `SymbolRefSmallVectorTy` -> `SymExprRefSmallVectorTy` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89987/new/ https://reviews.llvm.org/D89987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
