jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land.
LGTM with minor nit. ================ Comment at: clang/lib/AST/Decl.cpp:1481 LinkageInfo LinkageComputer::getDeclLinkageAndVisibility(const NamedDecl *D) { - return getLVForDecl(D, - LVComputationKind(usesTypeVisibility(D) - ? NamedDecl::VisibilityForType - : NamedDecl::VisibilityForValue)); + NamedDecl::ExplicitVisibilityKind EK = usesTypeVisibility(D) + ? NamedDecl::VisibilityForType ---------------- `clang-format` this please. This line seems to exceed 80 columns. ================ Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:1 +// REQUIRES: powerpc-registered-target + ---------------- Do you need this line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits