krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land.
Thank you! Your fix looks good for clang-format. I'm also not familiar with `DiagnosticsEngine`. It would be nice to follow-up with folks on that on either removing the defaulted ctor params and possibly adding assert-s in the ctor itself, or else updating the bits that assert that the client is not a `nullptr` to something that behaves reasonably in this case. There could be a good reason why the code is as-is; it would be nice if that is documented at the ctor or class level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
