aaron.ballman added a comment.

In D54943#2352196 <https://reviews.llvm.org/D54943#2352196>, @0x8000-0000 wrote:

> Would it be possible to split this review further, into "checking" and 
> "fixing" portions? I understand that fix-it portion is more difficult, and 
> sometimes results in multiple 'const' keywords being added, but for the past 
> year we have used the check as part of regular CI runs to flag where it needs 
> to be added by the engineers and for our use case it works fine that way - so 
> I would prefer to have at least the "report" part as part of upstream 
> Clang12, even if the 'fixup' comes later, due to the complexity of covering 
> all corner cases.

I wouldn't have an issue with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to