ychen added a comment.

IIUC, this is the NPM version of EP_EarlyAsPossible in legacy PM for O0, right? 
Between the choice of (1) [this patch and ] reusing all existing EP callbacks 
and letting optnone filtering out non-required passes (which I think does not 
work for `-disable-O0-optnone`) and (2) a separate EP callback, say, 
O0EPCallbacks, I would vote for the latter since it is more explicit and does 
exactly what we expect it to do. The cost is that we also need to add passes to 
O0EPCallbacks separately which I think is justified since required passes 
should be rare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89158/new/

https://reviews.llvm.org/D89158

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to