nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/index/Ref.h:91 RefKind Kind = RefKind::Unknown; + SymbolID Container; }; ---------------- kadircet wrote: > i am afraid we are going to have an indeterminate value here if for whatever > reason `Container` detection fails. (e.g. for macros, or if ASTNode.Parent > set to nullptr by libindex). > > Sent out https://reviews.llvm.org/D90397 to address the issue. Good catch, and thank you for addressing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89670/new/ https://reviews.llvm.org/D89670 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
