aaron.ballman added a reviewer: rsmith.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with some minor linting nits. Thanks!



================
Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1617
+TEST(ASTMatchersTest, ArgumentCountIs_CXXUnresolvedConstructExpr) {
+  auto Code = "template <typename T> struct S{}; template <typename T> void "
+              "x() { auto s = S<T>(); }";
----------------
The lint warnings here are actually correct and should be addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90553/new/

https://reviews.llvm.org/D90553

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D90553: Rename CXXUn... Aaron Ballman via Phabricator via cfe-commits

Reply via email to