kadircet added a comment.
Thanks, I skimmed over it (again) and I think this looks pretty great in
general. I couldn't take a look at the details yet, I would really appreciate
it if you could chop this one into smaller pieces (i know, i asked it before,
but this is still too big). I suppose something like:
- Changes in the XRefs side, introducing `{prepare,incoming,outgoing}
CallHierarchy` bits, relevant Protocol.h additions and unittests for those.
- Surfacing this in ClangdServer and ClangdLSPServer layer, with relevant
unit/lit tests. (I would be even more happier if you could split this in two
again one for each layer :) )
would be great.
If you can't split it up, that's also fine. I'll go over it eventually, it will
just take longer and probably be harder to remember where we left off after
each iteration :D
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89296/new/
https://reviews.llvm.org/D89296
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
