jansvoboda11 added a comment. Addressed review feedback. WDYT @Bigcheese?
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)&options::CC1Option) { \ + const auto &Extracted = EXTRACTOR(this->KEYPATH); \ + if (ALWAYS_EMIT || Extracted != DEFAULT_VALUE) \ ---------------- Bigcheese wrote: > Will this ever have an issue with lifetime? I can see various values for > `EXTRACTOR` causing issues here. https://abseil.io/tips/107 > > > It would be good to at least document somewhere the restrictions on > `EXTRACTOR`. Mentioned the reference lifetime extension in a comment near extractor definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits