jroelofs accepted this revision. jroelofs added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 + llvm::sys::path::append(SysRoot, "lib"); + getFilePaths().push_back(std::string(SysRoot.str())); + } ---------------- Is the explicit `std::string` ctor call necessary here? Since `SmallString` has an `operator std::string() const`, I think this can just be: ``` getFilePaths().push_back(SysRoot); ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91559/new/ https://reviews.llvm.org/D91559 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
