c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

LGTM

I've left one minor comment, if that suggestion works it should be fine to fix 
it before committing



================
Comment at: clang/lib/Sema/SemaExpr.cpp:7210-7212
+    const auto *BuiltinTy = FirstType->getAs<BuiltinType>();
+    if (!BuiltinTy || !BuiltinTy->isSizelessBuiltinType())
+      return false;
----------------
nit: I think you can just do:
```
if (!FirstType->isSizelessBuiltinType())
  return false;```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91262/new/

https://reviews.llvm.org/D91262

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to