ldionne accepted this revision as: libc++. ldionne added a comment. This revision is now accepted and ready to land.
In D91311#2400998 <https://reviews.llvm.org/D91311#2400998>, @dblaikie wrote: > A concrete/real-world example might be helpful, if you happen to have one on > hand. See what Richard included in his comment. @rsmith Ok, thanks for thinking this through. I do agree we'd most likely want a more powerful mechanism for creating these strings. I'm still only "meh" on the current design, especially because I see the ergonomics as a high barrier, but this isn't blocking. So, LGTM from libc++'s perspective -- thanks for having a discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
