tentzen marked 2 inline comments as done. tentzen added a comment. In D80344#2407250 <https://reviews.llvm.org/D80344#2407250>, @pengfei wrote:
> Do we need to consider FP exceptions in _try block? Yes, FP exception is handled as long as FP exceptions are not disabled (Ex via _controlfp() runtime) and FP exception code is filtered & handled via ___except() statement (Ex, ___except(GetExceptionCode()==EXCEPTION_FLT_INEXACT_RESULT)). ================ Comment at: clang/include/clang/Driver/Options.td:886 HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>; +def feh_asynch: Flag<["-"], "feh-asynch">, Group<f_Group>, + HelpText<"Enable EH Asynchronous exceptions">, Flags<[CC1Option]>; ---------------- pengfei wrote: > It's better to follow alphabetical for it and line 1531. really? I see some others are not in alphabetical order. it's natural to right besides fcxx_exceptions. ================ Comment at: clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp:1 +// RUN: %clang_cc1 -triple x86_64-windows -feh-asynch -fcxx-exceptions -fexceptions -fms-extensions -x c++ -Wno-implicit-function-declaration -S -emit-llvm %s -o - | FileCheck %s + ---------------- pengfei wrote: > Should this be a C file? I saw LangRef says they are used for C function. yes it's a C-function that can be placed in .cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
