the reason for splitting the check is we don't need this check at all in llvm instrument,-- as it's done per function. but I guess it does not matter much to move it in to create -- it's only called once per function.
On Wed, Apr 20, 2016 at 3:04 PM, David Li <davi...@google.com> wrote: > davidxl added inline comments. > > ================ > Comment at: lib/CodeGen/CodeGenPGO.cpp:47 > @@ +46,3 @@ > + // Create PGOFuncName meta data. > + if (!llvm::getPGOFuncNameMetadata(*Fn)) > + llvm::createPGOFuncNameMetadata(*Fn); > ---------------- > This check be folded into the creator. The creator interface name also > needs to be changed properly (created when needed) > > > http://reviews.llvm.org/D18624 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
