adamcz added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:201 + for (const auto &TLD : TLDs) { + if (MustInsertAfterLoc.isValid() && + SM.isBeforeInTranslationUnit(TLD->getBeginLoc(), MustInsertAfterLoc)) ---------------- kadircet wrote: > nit: maybe factor this into a lambda `bool IsUsingValidAt(SourceLocation)` ? Good idea. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92053/new/ https://reviews.llvm.org/D92053 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits