curdeius added inline comments.
================ Comment at: libcxx/include/functional:1759 typedef __base<_Rp(_ArgTypes...)> __func; __func* __f_; ---------------- All uses of `__f_` should also use `nullptr`. If my search counted correctly, there are 15 of them in `__value_func`. ================ Comment at: libcxx/include/locale:4335 { wbuffer_convert* __rt = 0; if (__cv_ != 0 && __bufptr_ != 0) ---------------- You missed this one. ================ Comment at: libcxx/include/locale:4340 if ((__cm_ & ios_base::out) && sync()) __rt = 0; } ---------------- And here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits