aeubanks accepted this revision.
aeubanks added a comment.
lgtm with comments
================
Comment at: clang/test/Misc/time-passes.c:2
+// Check that legacy pass manager could only use -ftime-report
+// RUN: %clang_cc1 -emit-obj -O1 -ftime-report %s -o /dev/null 2>&1 |
FileCheck %s --check-prefixes=TIME,LPM
+// RUN: not %clang_cc1 -emit-obj -O1 -ftime-report=per-pass %s -o /dev/null
2>&1 | FileCheck %s --check-prefixes=ERROR
----------------
this probably needs -fno-experimental-new-pass-manager so that when the NPM is
the default this doesn't fail
================
Comment at: llvm/lib/IR/PassTimingInfo.cpp:47
+ cl::desc("Time each pass run, printing elapsed time for each run on exit"),
+ cl::callback([](const bool &) { TimePassesIsEnabled = true; }));
+
----------------
is this necessary?
================
Comment at: llvm/test/Other/time-passes.ll:55
; TIME-NEW-DAG: TargetLibraryAnalysis
+; TIME-NEW-PER-PASS-DAG: InstCombinePass
+; TIME-NEW-PER-PASS-DAG: LICMPass
----------------
check that this doesn't appear multiple times under TIME-NEW-PER-PASS?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92436/new/
https://reviews.llvm.org/D92436
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
