zequanwu added inline comments.
================ Comment at: clang/test/CodeGen/attr-nomerge.cpp:17 + +[[clang::nomerge]] bool bar() { + return true; ---------------- rnk wrote: > I would leave this declaration as it was, so that all the statement attribute > test cases you wrote below remain as they were, and the attribute continues > to appear at the call site. > > The `f` declaration below gives you coverage of the free function declaration > case. I added `[[clang::nomerge]]` to `bar` in order to test that the generated IR should attach `nomerge` to call-sites which callee function already has this attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits