gulfem added a comment. > This is missing a lang ref entry for `nocallback` and the `attributes.ll` > test is arguably broken (see below).
Could you please elaborate on missing lang ref entry? Where that should be added? > The "definition" in `llvm/include/llvm/IR/Attributes.td` (see below), does > not match the the behavior of `clang/test/CodeGen/attr-leaf.c`. > As I mentioned before, this doesn't have a meaning on definitions and that > needs to be captured in the semantics (and preferably the FE). In that test case, `leaf` attribute is on the declaration. What kind of a test case do you suggest to add? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
