qchateau added a comment.

Here is the latest version, I believe it should mostly look like what you 
expect. Let me know if there is anything that you'd like me to change, it's 
totally fine to have a few more iterations on this diff.

I added a `CLANGD_ENABLE_MEMORY_CLEANUP` to make sure people can work around 
some weird linking issues with `malloc_trim` if necessary. I've noticed options 
such as `CLANGD_ENABLE_REMOTE` also appear in the files below, but as I have no 
idea what they are for, I did not add `CLANGD_ENABLE_MEMORY_CLEANUP` to them. 
Let me know if I should do anything concerning these files.

- clang-tools-extra/clangd/test/lit.site.cfg.py.in
- llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
- llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93452/new/

https://reviews.llvm.org/D93452

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to