abhina.sreeskantharajan added inline comments.
================ Comment at: clang/lib/Lex/LiteralSupport.cpp:1322-1323 + TranslationState = translationState; + if (Kind == tok::wide_string_literal) + TranslationState = TranslateToSystemCharset; + else if (isUTFLiteral(Kind)) ---------------- tahonermann wrote: > Converting wide character literals to the system encoding doesn't seem right > to me. For z/OS, this should presumably convert to the wide EBCDIC encoding, > but for all other supported platforms, the wide execution character set is > either UTF-16 or UTF-32 depending on the size of `wchar_t` (which may be > influenced by the `-fshort-wchar` option). Since we don't implement -fwide-exec-charset yet, what do you think should be the default behaviour for the interim? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D93031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits