Author: Arthur Eubanks Date: 2020-12-22T10:34:03-08:00 New Revision: b2e734d5f46d70c5a73dd16b0619c58eff6b8052
URL: https://github.com/llvm/llvm-project/commit/b2e734d5f46d70c5a73dd16b0619c58eff6b8052 DIFF: https://github.com/llvm/llvm-project/commit/b2e734d5f46d70c5a73dd16b0619c58eff6b8052.diff LOG: Revert "[clangd] zap a few warnings" This reverts commit 95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc. Depends on a reverted change. Added: Modified: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/index/remote/Client.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/DumpAST.cpp b/clang-tools-extra/clangd/DumpAST.cpp index 8f1b3f3a1aae..12698b42ef3e 100644 --- a/clang-tools-extra/clangd/DumpAST.cpp +++ b/clang-tools-extra/clangd/DumpAST.cpp @@ -143,7 +143,6 @@ class DumpVisitor : public RecursiveASTVisitor<DumpVisitor> { TEMPLATE_ARGUMENT_KIND(Declaration); TEMPLATE_ARGUMENT_KIND(Template); TEMPLATE_ARGUMENT_KIND(TemplateExpansion); - TEMPLATE_ARGUMENT_KIND(UncommonValue); #undef TEMPLATE_ARGUMENT_KIND } llvm_unreachable("Unhandled ArgKind enum"); diff --git a/clang-tools-extra/clangd/FindTarget.cpp b/clang-tools-extra/clangd/FindTarget.cpp index c5c7d71be661..3afd65522680 100644 --- a/clang-tools-extra/clangd/FindTarget.cpp +++ b/clang-tools-extra/clangd/FindTarget.cpp @@ -1069,7 +1069,6 @@ class ExplicitReferenceCollector case TemplateArgument::Pack: case TemplateArgument::Type: case TemplateArgument::Expression: - case TemplateArgument::UncommonValue: break; // Handled by VisitType and VisitExpression. }; return RecursiveASTVisitor::TraverseTemplateArgumentLoc(A); diff --git a/clang-tools-extra/clangd/index/remote/Client.cpp b/clang-tools-extra/clangd/index/remote/Client.cpp index a153a8812baf..b09dbf915e46 100644 --- a/clang-tools-extra/clangd/index/remote/Client.cpp +++ b/clang-tools-extra/clangd/index/remote/Client.cpp @@ -152,8 +152,7 @@ class IndexClient : public clangd::SymbolIndex { }); } - llvm::unique_function<bool(llvm::StringRef) const> - indexedFiles() const override { + llvm::unique_function<bool(llvm::StringRef) const> indexedFiles() const { // FIXME: For now we always return "false" regardless of whether the file // was indexed or not. A possible implementation could be based on // the idea that we do not want to send a request at every _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
