[PATCH] D93940: Add a check for blocking types and functions.

[Vasily Kulikov via Phabricator via cfe-commits]

segoon updated this revision to Diff 314092.
segoon added a comment.

up


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93940/new/

https://reviews.llvm.org/D93940

Files:
  clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp


Index: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp
+++ clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp
@@ -314,12 +314,6 @@
     }
   }
 
-  const auto *L = Result.Nodes.getNodeAs<NestedNameSpecifierLoc>("lock");
-  if (L) {
-    diag(L->getBeginLoc(), "type may sleep and is not coroutine-safe")
-        << SourceRange(L->getBeginLoc(), L->getEndLoc());
-  }
-
   const auto *Atomic = Result.Nodes.getNodeAs<ValueDecl>(kAtomic);
   if (Atomic) {
     const auto *Lockfree = Result.Nodes.getNodeAs<VarDecl>(kLockfree);



Index: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp
+++ clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp
@@ -314,12 +314,6 @@
     }
   }
 
-  const auto *L = Result.Nodes.getNodeAs<NestedNameSpecifierLoc>("lock");
-  if (L) {
-    diag(L->getBeginLoc(), "type may sleep and is not coroutine-safe")
-        << SourceRange(L->getBeginLoc(), L->getEndLoc());
-  }
-
   const auto *Atomic = Result.Nodes.getNodeAs<ValueDecl>(kAtomic);
   if (Atomic) {
     const auto *Lockfree = Result.Nodes.getNodeAs<VarDecl>(kLockfree);

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits