hubert.reinterpretcast added inline comments.
================ Comment at: clang/lib/Sema/SemaAttr.cpp:65-67 + // The #pragma align/pack affected a record in an included file, so Clang + // should warn when that pragma was written in a file that included the + // included file. ---------------- Remove extra space; add missing "the". ================ Comment at: clang/lib/Sema/SemaAttr.cpp:365-367 + // FIXME: AlignPackStack may contain both #pragma align and #pragma pack + // information, diagnostics below might not be accurate if we have mixed + // pragmas. ---------------- It may be helpful to pre-commit tests with the incorrect behaviour as part of the NFC patch. ================ Comment at: clang/lib/Sema/SemaAttr.cpp:385-387 + // FIXME: AlignPackStack may contain both #pragma align and #pragma pack + // information, diagnostics below might not be accurate if we have mixed + // pragmas. ---------------- Same comment re: pre-committing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/D93901 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
