steven.zhang added a comment. Some code style comments.
================ Comment at: clang/include/clang/Driver/Options.td:2603 def mno_spe : Flag<["-"], "mno-spe">, Group<m_ppc_Features_Group>; +def mefpu2 : Flag<["-"], "mefpu2">, Group<m_ppc_Features_Group>; def mabi_EQ_vec_extabi : Flag<["-"], "mabi=vec-extabi">, Group<m_Group>, Flags<[CC1Option]>, ---------------- Maybe, clang/docs/ClangCommandLineReference.rst need to be updated also ? ================ Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:707 + bool hasEFPU2() const; + ---------------- I think we don't need such wrap but just call Subtarget.hasEFPU2() directly. ================ Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:103 bool HasSPE; + bool HasEFPU2; bool HasVSX; ---------------- Miss to initialize it ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92935/new/ https://reviews.llvm.org/D92935 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
