vsavchenko added inline comments.
================ Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:822 + /// calling the parameter itself, but rather uses it as the argument. + template <class CallLikeExpr> + void checkIndirectCall(const CallLikeExpr *CallOrMessage) { ---------------- NoQ wrote: > vsavchenko wrote: > > NoQ wrote: > > > Did you consider `AnyCall`? That's a universal wrapper for all kinds of > > > AST calls for exactly these cases. It's not super compile-time but it > > > adds a lot of convenience. (Also uh-oh, its doxygen page seems to be > > > broken). It's ok if you find it unsuitable but i kind of still want to > > > popularize it. > > It doesn't seem to have iteration over arguments. > If you see some actual benefits and that's the only thing that's holding you > back, you should add it. Or is it hard to add for whatever reason? As of now, I prefer not to pay extra runtime costs while I can. When I do the C++ part of it, I'll consider it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits