aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a commenting nit.



================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2288-2289
     // TODO: If we could match on explicit instantiations of function 
templates,
     // this would be EXPECT_TRUE.
+    // See Sema::ActOnExplicitInstantiation,
     EXPECT_FALSE(
----------------



================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2337
+  {
+    // Instantiated, out-of-line methods are not matchable
+    auto M =
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94032/new/

https://reviews.llvm.org/D94032

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to