sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for all the changes @david-arm!
================
Comment at: clang/lib/AST/AttrImpl.cpp:46
+ else if (state == FixedWidth || state == ScalableWidth) {
+ if (value) {
+ value->printPretty(OS, nullptr, Policy);
----------------
nit:
```if (value) {
value->printPretty(OS, nullptr, Policy);
OS << ", ";
}
OS << (state == ScalableWidth ? "scalable" : "fixed";```
?
================
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:309
+ (Attrs.VectorizeScalable == LoopAttributes::Disable &&
+ Attrs.VectorizeWidth == 0)) {
bool AttrVal = Attrs.VectorizeEnable != LoopAttributes::Disable;
----------------
nit: `!= 1` (it should be functionally the same because the >1 is already
caught above, but this is specifically testing that VF=1 (scalar) is not
specified)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89031/new/
https://reviews.llvm.org/D89031
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
