dblaikie added a comment.

For 3 code paths (that seem fairly independent from one another) I'd only 
really expect to see 3 variables in the test - one to exercise each codepath. 
What's the reason for the larger set of test cases?

Then it might be simpler just to include 6 variables, one of each kind with the 
attribute, one of each kind without. & I think you could check this reliably 
with:

CHECK: DIGlobalVariable
CHECK-NEXT: "name"

repeated three times with a CHECK-NOT: DIGlobalVariable at the end - that way 
the CHECK wouldn't skip past an existing variable, and you'd check you got the 
right ones. I think.


http://reviews.llvm.org/D19567



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to