usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land.
LG. Thanks! ================ Comment at: clang-tools-extra/clangd/XRefs.cpp:1324 + + llvm::DenseSet<SymbolID> OverrideSymbols; + if (Index) { ---------------- nit: s/OverrideSymbols/Overrides ================ Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1834 +TEST(FindReferences, IncludeOverrides) { + llvm::StringRef Test = ---------------- nit: May be include tests for CRTP too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94390/new/ https://reviews.llvm.org/D94390 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits