dblaikie added a comment.

Ah, seems I was confused by the patch title - it looks like these values aren't 
used for FlagFwdDecl records - forward declarations bail out 3356, not using 
the file/line created on 3338/3339.

Seems like this change might lead to a situation of files but no line numbers, 
which seems a bit strange to me - well, at least for __va_list_tag, which isn't 
anymore associated with the file than with the line. Perhaps both should be 
addressed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94735/new/

https://reviews.llvm.org/D94735

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to