adamcz added inline comments.
================ Comment at: clang-tools-extra/clangd/Quality.cpp:349 + }; + DeriveASTSignals(); // Declarations are scoped, others (like macros) are assumed global. ---------------- Maybe it's just me, but using a lambda like this seems quite confusing. I don't think it improves readability. Maybe just make it a separate method? Or inline here, but without lambda? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
