qchateau added a comment.

I applied your suggestion as I agree with both. I chose to use 
`Opts.AsyncThreadsCount` instead of a hard-coded constant. This way the 
"formatting speed" will grow as the user allow more parallelism, which IMO 
makes sense.

I agree the implementation had drawbacks but this is the ever-ending problem of 
non-preemptable tasks. You can land this if this looks good to you.

Commit email: quentin.chat...@gmail.com


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94875/new/

https://reviews.llvm.org/D94875

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to