aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land.
This does not yet have i64x2 version of the instructions in https://github.com/WebAssembly/simd/pull/395 yet, right? ================ Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1279 + (I32x4.vt (int_wasm_widen_signed + (I8x16.vt V128:$vec), (i32 timm:$idx))))], + "i32x4.widen_i8x16_s\t$dst, $vec, $idx", ---------------- I think this is the first time we use `timm` in this file... Haven't we used `LaneIdxN` for these? The same for `WIDEN_I8x16_TO_I32x4_U`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95557/new/ https://reviews.llvm.org/D95557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
