jansvoboda11 added a comment.

I've changed this patch so that the errors and debugging output goes to 
`DiagnosticsEngine`.

Also, I switched back to the original solution, where we always round-trip when 
Clang is built certain way (this time not when CMake was configured with 
`-DLLVM_ENABLE_ASSERTIONS=ON`, but with `-DCLANG_ROUND_TRIP_CC1_ARGS=ON`). The 
problem with the previous solution (passing `-round-trip-args` from the driver 
to `-cc1`) is that a lot of tests invoke `-cc1` directly, not through the 
driver. We want to test round-tripping on such tests as well, but shouldn't 
pollute them with `-round-trip-args` or force them to go through the driver. 
I've considered enabling round-tripping through an environment variable, but 
the problem is that the, the environment variable is not propagated when 
running lit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94472/new/

https://reviews.llvm.org/D94472

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to