aeubanks added inline comments.

================
Comment at: compiler-rt/test/profile/instrprof-gc-sections.c:30
+// RUN: llvm-nm -jgU %t | grep -vE "main|_start|_IO_stdin_used|__libc_.*" > 
%t.code.syms
+// RUN: diff %t.nocode.syms %t.code.syms
+
----------------
phosek wrote:
> MaskRay wrote:
> > This fails on my machine (cc @akuegel). If I use `diff -u`:
> > 
> > ```
> > --- 
> > /tmp/RelA/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.nocode.syms
> >    2021-02-01 22:14:22.850222346 -0800
> > +++ 
> > /tmp/RelA/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.code.syms
> >      2021-02-01 22:14:22.854222358 -0800
> > @@ -3,6 +3,5 @@
> >  __prof_cnts_sect_data
> >  __prof_data_sect_data
> >  __prof_nms_sect_data
> > -__prof_orderfile_sect_data
> >  __prof_vnodes_sect_data
> >  lprofDirMode
> > ```
> > 
> > At the worst we can temporarily disable it (if others report issues as 
> > well).
> What's your build setup? I ran `check-profile` on my Linux workstation just 
> now but haven't seen this issue.
This also fails on my machine:
$ cmake -GNinja -DLLVM_ENABLE_PROJECTS='clang;compiler-rt;lld' 
-DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_LLD=ON ..
$ ninja check-profile


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76802/new/

https://reviews.llvm.org/D76802

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to