LukasHanel created this revision.
Herald added a subscriber: nullptr.cpp.
LukasHanel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D96080
Files:
clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
Index: clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
+++ clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
@@ -30,14 +30,13 @@
forEachDescendant(
returnStmt(hasReturnValue(Int0Var)).bind("return-to-void")),
unless(hasDescendant(returnStmt(unless(hasReturnValue(Int0Var))))),
- unless(hasDescendant(
- binaryOperator(isAssignmentOperator(),
- hasLHS(declRefExpr(
- to(varDecl(equalsBoundNode("retvar")))))))),
- unless(hasDescendant(
- cxxOperatorCallExpr(isAssignmentOperator(),
- hasLHS(hasDescendant(declRefExpr(
- to(varDecl(equalsBoundNode("retvar"))))))))),
+ unless(hasDescendant(binaryOperator(
+ isAssignmentOperator(),
+ hasLHS(declRefExpr(to(varDecl(equalsBoundNode("retvar")))))))),
+ unless(hasDescendant(cxxOperatorCallExpr(
+ isAssignmentOperator(),
+ hasLHS(hasDescendant(
+ declRefExpr(to(varDecl(equalsBoundNode("retvar"))))))))),
unless(hasDescendant(
unaryOperator(hasAnyOperatorName("++", "--", "&"),
hasUnaryOperand(ignoringImplicit(declRefExpr(
Index: clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
+++ clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp
@@ -30,14 +30,13 @@
forEachDescendant(
returnStmt(hasReturnValue(Int0Var)).bind("return-to-void")),
unless(hasDescendant(returnStmt(unless(hasReturnValue(Int0Var))))),
- unless(hasDescendant(
- binaryOperator(isAssignmentOperator(),
- hasLHS(declRefExpr(
- to(varDecl(equalsBoundNode("retvar")))))))),
- unless(hasDescendant(
- cxxOperatorCallExpr(isAssignmentOperator(),
- hasLHS(hasDescendant(declRefExpr(
- to(varDecl(equalsBoundNode("retvar"))))))))),
+ unless(hasDescendant(binaryOperator(
+ isAssignmentOperator(),
+ hasLHS(declRefExpr(to(varDecl(equalsBoundNode("retvar")))))))),
+ unless(hasDescendant(cxxOperatorCallExpr(
+ isAssignmentOperator(),
+ hasLHS(hasDescendant(
+ declRefExpr(to(varDecl(equalsBoundNode("retvar"))))))))),
unless(hasDescendant(
unaryOperator(hasAnyOperatorName("++", "--", "&"),
hasUnaryOperand(ignoringImplicit(declRefExpr(
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
