tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
Few test nits. LGTM in principle. ================ Comment at: clang/test/Driver/hip-cuid.hip:98 + +// RUN: rm -rf %t.out + ---------------- Is it necessary? The next 'RUN' command would overwrite the temp file anyways. Also, you don't have to call all temporary files `%t.out`. You could use `%t-1.out`, etc and leave the cleanup to the test driver. ================ Comment at: clang/test/Driver/hip-cuid.hip:100-102 +// RUN: %clang -### -x hip -target x86_64-unknown-linux-gnu \ +// RUN: --offload-arch=gfx906 -c -nogpulib -fuse-cuid=hash \ +// RUN: %S/Inputs/hip_multiple_inputs/a.cu >%t.out 2>&1 ---------------- Putting `RUN` down in the test file makes them easy to miss. Maybe these should be in their own `hip-cuid-rdc.hip` test structured in a conventional way -- RUN lines first, followed by checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https://reviews.llvm.org/D95007 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
