kbobyrev added a comment.
This likely needs some further thought on conflict detection. Assume we have
void foo(int Argument^); // case 1
void foo(int OhWait); // case 2
void foo(int Argument); // case 3
void foo(int AnotherOne) {} // case 4
What should we do when renaming `Argument`? Just rename all of them? Only
rename in places where the name matches the original one (case 3)? Bail out and
report an error? Also, there is no easy way to check all of these cases within
our existing conflict detection pipeline: IIUC we'd need to walk the whole AST
again for that (like we do in this patch within the rename pipeline).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96324/new/
https://reviews.llvm.org/D96324
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
