t.p.northover added inline comments.
================ Comment at: clang/test/CodeGen/aarch64-neon-sm4-sm3.c:5 + +// RUN: not %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ +// RUN: -S -emit-llvm -o - %s 2>&1 | FileCheck --check-prefix=CHECK-NO-CRYPTO %s ---------------- apazos wrote: > The test is written for aarch64 triple, in addition @t.p.northover might want > to add arm64 triple checks. Tim what do you think? Thanks for thinking of us, but generally I don't think it's worth duplicating tests along those lines, it's really difficult to write something that cares about the difference between `arm64` and `aarch64`. `linux-gnu` vs `apple-ios` (or others, these days) is more likely to be an issue, but even there I tend to think it's fine to just check one unless there's a specific reason to think it'll affect the targets differently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
