JonChesterfield added a comment.

In D96877#2569863 <https://reviews.llvm.org/D96877#2569863>, @tianshilei1992 
wrote:

> Please also update the test.
>
> In D96877#2569861 <https://reviews.llvm.org/D96877#2569861>, @JonChesterfield 
> wrote:
>
>> Suggestion is to resolve libomptarget-nvptx-unknown.bc to a cp of the 
>> bitcode libary built for the newest sm_xx and ptx version clang knows of.
>
> Why a copy instead of a symlink?

I don't trust symlinks to survive packaging (tar or deb) or copying around the 
filesystem during install. Possibly showing scars from windows development 
there.

Tests passing locally, as expected. Do you mean add a new one that jury rigs 
cuda version and has a libomptarget-nvptx-unknown.bc on disk somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96877/new/

https://reviews.llvm.org/D96877

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to