vabridgers added a comment.

Polite ping. This is a small and simple change, my only doubt is the test 
coverage. But frankly I see none of the literals are covered in any of the test 
cases (unless I'm missing something). Could I get some guidance on required 
test coverage for this simple change, or a LGTM?

Thanks - Vince


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96905/new/

https://reviews.llvm.org/D96905

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to