kadircet added a comment.
mostly LG, can you also add some tests?
================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:695
+ if (Insert.empty() && FixIt.InsertFromRange.isValid()) {
+ bool InvalidInsert = false;
+ Insert = Lexer::getSourceText(FixIt.InsertFromRange, SM, *LangOpts,
----------------
nit: I would rather make `!Invalid` a condition and just make use of it in here
as well.
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:555
+ auto Insert = Lexer::getSourceText(FixIt.InsertFromRange, M, L, &Invalid);
+ if (!Invalid)
+ Result.newText = Insert.str();
----------------
it feels like correct semantics would be to make this function fail now. as the
resulting value will likely be used for editing the source code and we don't
want to propagate some garbage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97123/new/
https://reviews.llvm.org/D97123
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
