jroelofs added inline comments.
================ Comment at: clang/lib/Sema/SemaAttr.cpp:304 + if (llvm::Error E = Context.getTargetInfo().isValidSectionSpecifier(SecName)) + Diag(PragmaLoc, diag::err_pragma_section_invalid_for_target) ---------------- t.p.northover wrote: > Shouldn't this block return so the section doesn't get marked as valid later? yes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
