JonChesterfield added a comment.

Replacing `CC1Args.push_back("-emit-llvm-bc");` with 
`CC1Args.push_back("-emit-llvm-bc");` as suggested on the call does not work. 
This hook is downstream of the clang driver, so all it does under save temps is 
lead to `clang -E -emit-llvm`, which generated llvm as requested, that cannot 
be fed into `clang -x cpp-output`.

The handling of `clang -save-temps` that strips out `emit-llvm` from the 
preprocessor pass runs before this.

I do not want to change the semantics of emit-llvm, emit-llvm-bc, or save-temps 
to help out the amdgcn openmp target. I can see that breaking lots of other 
users of clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96769/new/

https://reviews.llvm.org/D96769

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to