LuoYuanke added inline comments.
================ Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:88 + +template <Intrinsic::ID IntrID, + typename = typename std::enable_if< ---------------- pengfei wrote: > LuoYuanke wrote: > > pengfei wrote: > > > Can we just use `template <bool IsLoad>`? I think it also can reduce the > > > branch. > > Why do we need a template instead of passing a parameter `bool IsLoad`? > Bing thought template instantiation can avoid the condition code to turn into > branch instructions. That may be arguable what benefit more. Code size saving or branch instructions avoiding. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
